Skip to content

add a test for coverage of configuration validation of plugins used at HLT - #51295

Merged
cmsbuild merged 1 commit into
cms-sw:masterfrom
mmusich:mm_testPluginConfigValidationCoverage
Jun 24, 2026
Merged

add a test for coverage of configuration validation of plugins used at HLT#51295
cmsbuild merged 1 commit into
cms-sw:masterfrom
mmusich:mm_testPluginConfigValidationCoverage

Conversation

@mmusich

@mmusich mmusich commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

PR description:

Title says it all. To make sure we don't accumulate more cases as the one included at #47275.

PR validation:

scram b runtests_test_PluginConfigValidationCoverage runs for both:

when this commit is cherry-picked.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport, no backport needed.

@cmsbuild

cmsbuild commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

cms-bot internal usage

@cmsbuild

Copy link
Copy Markdown
Contributor

@cmsbuild

Copy link
Copy Markdown
Contributor

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @cmsbuild, @mmusich can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@mmusich

mmusich commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@cmsbuild, please test

@cmsbuild

Copy link
Copy Markdown
Contributor

+1

Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-75a0a9/54217/summary.html
COMMIT: 9e97365
CMSSW: CMSSW_20_1_X_2026-06-23-1100/el9_amd64_gcc13
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/51295/54217/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

There are some workflows for which there are errors in the baseline:
2022.0010001 step 1
2023.0020001 step 1
2024.0000001 step 1
2024.0010001 step 1
2024.0020001 step 1
2024.0030001 step 1
2024.0040001 step 1
2024.0050001 step 1
2024.0060001 step 1
2024.0070001 step 1
2025.0000002 step 1
2025.0010001 step 1
34634.0 step 2
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Summary:

  • You potentially added 14 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2533874
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2533856
  • DQMHistoTests: Total skipped: 18
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 145 log files, 113 edm output root files, 32 DQM output files

@mmusich

mmusich commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

+hlt

@cmsbuild

Copy link
Copy Markdown
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @mandrenguyen, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@mandrenguyen

Copy link
Copy Markdown
Contributor

+1

@cmsbuild
cmsbuild merged commit cb21a96 into cms-sw:master Jun 24, 2026
10 checks passed
@mmusich
mmusich deleted the mm_testPluginConfigValidationCoverage branch June 24, 2026 11:16
NJManganelli pushed a commit to NJManganelli/cmssw that referenced this pull request Jul 25, 2026
…ationCoverage

add a test for coverage of configuration validation of plugins used at HLT
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants